chore(key-value): remove redundant exception logging #21702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the
key-value
commands are logging exceptions despite reraising the exception. This causes unnecessary noise on logs if the caller is anticipating a failure, which can be caught by the reraisedKeyValue(Get|Create|Delete|Update)FailedError
if needed. In addition, the Upsert command didn't have an exception of its own, and was not catching theKeyValueCreateFailedError
exception, causing an expectedValueError
to go unnoticed:superset/superset/key_value/commands/create.py
Lines 82 to 88 in de444d4
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION