fix: add logging to alerts and reports to find non-triggering issues #21684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
reviewed
Oct 3, 2022
superset/reports/commands/alert.py
Outdated
| @@ -166,6 +166,9 @@ def _execute_query(self) -> pd.DataFrame: | |||
| logger.warning("A timeout occurred while executing the alert query: %s", ex) | |||
| raise AlertQueryTimeout() from ex | |||
| except Exception as ex: | |||
| logger.warning( | |||
| "A general exception occurred while executing the alert query: %s", ex | |||
| ) | |||
| raise AlertQueryError(message=str(ex)) from ex | |||
There was a problem hiding this comment.
does this exception already log this error?
There was a problem hiding this comment.
Yes but i'm curious to see what this error is on it's face because it could be empty.
Codecov Report
@@ Coverage Diff @@
## master #21684 +/- ##
==========================================
+ Coverage 66.80% 66.82% +0.02%
==========================================
Files 1799 1799
Lines 68825 68830 +5
Branches 7314 7314
==========================================
+ Hits 45976 45994 +18
+ Misses 20970 20957 -13
Partials 1879 1879
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
reviewed
Oct 3, 2022
eschutho
approved these changes
Oct 3, 2022
|
🏷️ preset:2022.39 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 3, 2022
…pache#21684) (cherry picked from commit 84c3cf6)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Alerts and reports has had some issues where some users report their reports not triggering at their validate time. This pr is the first step in adding some logs to gather error feedback to correct this problem.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION