Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch tab on drag hover #21648

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

When dragging a chart to a tab, the dashboard should switch to the target tab instead of scrolling upward.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-09-29.at.10.57.17.AM.mov
Screen.Recording.2022-09-29.at.10.47.06.AM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #21648 (a4fd22a) into master (ab7cfec) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master   #21648      +/-   ##
==========================================
- Coverage   66.82%   66.82%   -0.01%     
==========================================
  Files        1798     1798              
  Lines       68781    68785       +4     
  Branches     7326     7326              
==========================================
+ Hits        45962    45963       +1     
- Misses      20944    20947       +3     
  Partials     1875     1875              
Flag Coverage Δ
javascript 53.14% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/dashboard/components/dnd/DragDroppable.jsx 76.92% <ø> (ø)
...ontend/src/dashboard/components/dnd/handleHover.js 9.09% <0.00%> (-0.91%) ⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx 80.41% <0.00%> (-0.84%) ⬇️
...nd/src/dashboard/components/gridComponents/Tab.jsx 82.35% <50.00%> (-1.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit b2a360f into apache:master Sep 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants