fix: respect chart cache timeout setting #21637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mayurnewase
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21637 +/- ##
===========================================
- Coverage 66.82% 55.45% -11.38%
===========================================
Files 1797 1797
Lines 68753 68765 +12
Branches 7325 7325
===========================================
- Hits 45944 38132 -7812
- Misses 20934 28758 +7824
Partials 1875 1875
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
reviewed
Sep 29, 2022
|
ok
…------------------ 原始邮件 ------------------
发件人: "apache/superset" ***@***.***>;
发送时间: 2022年9月29日(星期四) 下午2:28
***@***.***>;
***@***.***>;
主题: Re: [apache/superset] fix: respect chart cache timeout setting (PR #21637)
@villebro commented on this pull request.
In superset/common/query_context.py:
> @@ -46,6 +47,7 @@ class QueryContext: enforce_numerical_metrics: ClassVar[bool] = True datasource: BaseDatasource + slice_id: Optional[int] = None
..I'm assuming this should be slice: Optional[Slice]?
⬇️ Suggested change - slice_id: Optional[int] = None + slice: Optional[Slice] = None
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
villebro
approved these changes
Sep 29, 2022
AAfghahi
pushed a commit
that referenced
this pull request
Nov 17, 2022
AAfghahi
pushed a commit
that referenced
this pull request
Nov 18, 2022
AAfghahi
pushed a commit
that referenced
this pull request
Dec 15, 2022
mistercrunch
added
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes: #21635
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
start redis locally, and setup redis cache in config for data
create any chart on 1 dataset
set dataset cache timeout to 120 seconds
set chart cache timeout to 20 seconds (from properties modal).
open chart, and click on update chart
use redis cli, to check the expiry set on the cache key using ttl {cache_key} -> ishould be around 20 seconds.
after 20 seconds, click on update chart -> should not show
cachedtag on top right corner.ADDITIONAL INFORMATION