-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Color consistency E2E tests #21622
Conversation
…Z/superset into chore/color-consistency-e2e
Codecov Report
@@ Coverage Diff @@
## master #21622 +/- ##
===========================================
- Coverage 66.82% 55.55% -11.27%
===========================================
Files 1805 1805
Lines 69070 69070
Branches 7373 7373
===========================================
- Hits 46159 38375 -7784
- Misses 21005 28789 +7784
Partials 1906 1906
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
Show resolved
Hide resolved
…Z/superset into chore/color-consistency-e2e
…e/color-consistency-e2e
Opening for an initial round of reviews. This PR will be rebased once the related color consistency PR will be merged |
…Z/superset into chore/color-consistency-e2e
…Z/superset into chore/color-consistency-e2e
…Z/superset into chore/color-consistency-e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…Z/superset into feat-color-enhancement
…Z/superset into chore/color-consistency-e2e
…Z/superset into chore/color-consistency-e2e
…e/color-consistency-e2e
SUMMARY
E2E tests for color consistency in Dashboard. The CI should pass when the related PR is merged.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION