Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing '.git' from web url references in Yeoman generator's package.json #21611

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

Just a couple of quick fixes to urls in the Yeoman Generator's package.json file

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Copy/paste the URLs into your browser and make sure they're correct.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #21611 (22cfdd0) into master (e3ddd0b) will not change coverage.
The diff coverage is n/a.

❗ Current head 22cfdd0 differs from pull request most recent head 4e566a4. Consider uploading reports for the commit 4e566a4 to get more accurate results

@@           Coverage Diff           @@
##           master   #21611   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files        1796     1796           
  Lines       68716    68716           
  Branches     7313     7313           
=======================================
  Hits        45843    45843           
  Misses      21011    21011           
  Partials     1862     1862           
Flag Coverage Δ
javascript 52.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 23cd5c9 into master Sep 28, 2022
@rusackas rusackas deleted the url-typos branch September 28, 2022 04:32
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants