Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add databricks form #21573

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Sep 23, 2022

SUMMARY

Adds a databricks db connection form

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Sqlalchemy uri only
_DEV__Superset

After: now also includes a dynamic form option
_DEV__Superset

TESTING INSTRUCTIONS

create and edit databricks database with the new form

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #21573 (7bd15eb) into master (3bc0865) will decrease coverage by 11.39%.
The diff coverage is 56.00%.

❗ Current head 7bd15eb differs from pull request most recent head ad5d0e6. Consider uploading reports for the commit ad5d0e6 to get more accurate results

@@             Coverage Diff             @@
##           master   #21573       +/-   ##
===========================================
- Coverage   66.92%   55.52%   -11.40%     
===========================================
  Files        1835     1846       +11     
  Lines       69988    70382      +394     
  Branches     7612     7683       +71     
===========================================
- Hits        46839    39080     -7759     
- Misses      21183    29310     +8127     
- Partials     1966     1992       +26     
Flag Coverage Δ
hive ?
mysql ?
postgres ?
presto 52.42% <45.28%> (-0.05%) ⬇️
python 57.42% <58.49%> (-23.92%) ⬇️
sqlite ?
unit 50.87% <57.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...i-chart-controls/src/utils/expandControlConfig.tsx 100.00% <ø> (ø)
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <ø> (ø)
...superset-ui-core/src/query/types/PostProcessing.ts 100.00% <ø> (ø)
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...BigNumber/BigNumberWithTrendline/transformProps.ts 47.82% <ø> (ø)
...ins/plugin-chart-echarts/src/BoxPlot/buildQuery.ts 66.66% <ø> (ø)
...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts 5.55% <ø> (ø)
... and 375 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho force-pushed the elizabeth/databricks-form-db branch from 85f70d0 to 23cfc67 Compare September 23, 2022 23:24
@eschutho eschutho marked this pull request as draft September 26, 2022 21:55
@eschutho eschutho force-pushed the elizabeth/databricks-form-db branch 2 times, most recently from 7581c0b to f40220e Compare October 14, 2022 22:12
@eschutho eschutho marked this pull request as ready for review October 14, 2022 22:12
@eschutho eschutho force-pushed the elizabeth/databricks-form-db branch 2 times, most recently from c6891ab to 9165523 Compare October 14, 2022 23:27
@eschutho
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://34.221.86.119:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho force-pushed the elizabeth/databricks-form-db branch 2 times, most recently from b1637d4 to dd12e7c Compare October 19, 2022 18:51
@eschutho eschutho force-pushed the elizabeth/databricks-form-db branch from dd12e7c to ad5d0e6 Compare December 1, 2022 01:15
@eschutho eschutho merged commit 5c77f1a into apache:master Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants