Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple columns with time grain in Table Chart #21547

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Sep 22, 2022

SUMMARY

This PR implements multiple columns with time grain in the Table Chart when Generic Axis is enabled. This PR should wait until PivotTable PR is merged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #21547 (59013bb) into master (e671d80) will decrease coverage by 0.01%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##           master   #21547      +/-   ##
==========================================
- Coverage   66.65%   66.64%   -0.02%     
==========================================
  Files        1793     1793              
  Lines       68559    68574      +15     
  Branches     7294     7300       +6     
==========================================
  Hits        45701    45701              
- Misses      20991    21003      +12     
- Partials     1867     1870       +3     
Flag Coverage Δ
javascript 52.80% <6.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 53.12% <0.00%> (-9.84%) ⬇️
...ntend/plugins/plugin-chart-table/src/buildQuery.ts 56.25% <16.66%> (-4.77%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 22, 2022
@zhaoyongjie zhaoyongjie changed the title [WIP]feat: support multiple columns with time grain in Table Chart feat: support multiple columns with time grain in Table Chart Sep 22, 2022
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit d67b046 into apache:master Sep 23, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants