Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): fix Pivot Table V2 dragPreview in the dashboard #21539

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix(dashboard): fix Pivot Table V2 dragPreview in the dashboard #21539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
import { css, styled } from '@superset-ui/core';

export const Styles = styled.div`
${({ theme }) => css`
${({ theme, isDashboardEditMode }) => css`
table.pvtTable {
position: relative;
position: ${isDashboardEditMode ? 'inherit' : 'relative'};
font-size: ${theme.typography.sizes.s}px;
text-align: left;
margin: ${theme.gridUnit}px;
Expand All @@ -32,7 +32,7 @@ export const Styles = styled.div`
}

table thead {
position: sticky;
position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
top: 0;
}

Expand All @@ -51,7 +51,7 @@ export const Styles = styled.div`
}

table.pvtTable tbody tr.pvtRowTotals {
position: sticky;
position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
bottom: 0;
}

Expand Down
6 changes: 5 additions & 1 deletion superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,10 @@ export class TableRenderer extends React.Component {
);
}

isDashboardEditMode() {
return document.contains(document.querySelector('.dashboard--editing'));
}

render() {
if (this.cachedProps !== this.props) {
this.cachedProps = this.props;
Expand Down Expand Up @@ -867,7 +871,7 @@ export class TableRenderer extends React.Component {
};

return (
<Styles>
<Styles isDashboardEditMode={this.isDashboardEditMode()}>
<table className="pvtTable" role="grid">
<thead>
{colAttrs.map((c, j) =>
Expand Down