fix(table-chart): don't color empty cells in table chart with color formatters #21501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If cell value is null don't color it in table chart with conditional formatting, will fix pivot table later if it has similar issue.
fixes: #21341
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
create virtual dataset with following query
SELECT 34523.323 as gmv, 24523.323 as fm, '1' as shem, '1' as gr UNION all SELECT 325323543.323 as gmv, 125323543.323 as fm, '2' as shem, '1' as gr UNION all SELECT null as gmv, 4764545.323 as fm, '3' as shem, '2' as gr UNION all SELECT -10 as gmv, 35254525.323 as fm, '4' as shem, '2' as gr
create table chart with raw records, and from the customize tab set the conditional color formatter on column
gmv
with condition< 1
test only colored cell is
-10
ingmv
column.ADDITIONAL INFORMATION