-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: permission sqlalchemy events #21454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21454 +/- ##
===========================================
- Coverage 66.53% 55.31% -11.22%
===========================================
Files 1791 1791
Lines 68599 68537 -62
Branches 7320 7320
===========================================
- Hits 45645 37914 -7731
- Misses 21064 28733 +7669
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh - all these SQLA hooks :(
(cherry picked from commit 64d216a)
🏷️ preset:2022.35 |
SUMMARY
There can be cases where a session will not be able to query records just created by a SQLA event using a connection,
on:
This PR fixes this problem by querying just inserted PVM's using connections also.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION