-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow clickhouse dbs with timestamps to visualize queries #21446
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21446 +/- ##
==========================================
- Coverage 66.71% 66.70% -0.01%
==========================================
Files 1796 1796
Lines 68716 68720 +4
Branches 7313 7313
==========================================
Hits 45843 45843
- Misses 21011 21015 +4
Partials 1862 1862
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@hughhhh Could you post both SQL that changes before and after? Thanks! |
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://34.220.56.32:8080. Credentials are |
Tested in preset workspace, able to see date column in chart-power query in explore. LGTM |
Is the problem that the Clickhouse driver is returning columns that are dictionaries instead of |
@betodealmeida the implementation for columns in the |
/testenv up |
@yousoph Ephemeral environment creation failed. Please check the Actions logs for details. |
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.90.3.173:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
🏷️ preset:2022.39 |
SUMMARY
Clickhouse queries would fail with timestamps since we duck typing the columns types. This PR fixes this issue, but currently looking into a more robust solution for standardizing columns in side this
ExploreMixin
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION