Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moves the DeprecatedSelect to its own folder #21445

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves the DeprecatedSelect and its related components to a specific folder in src/components/DeprecatedSelect. This is important to isolate this code from the current Select implementation in src/components/Select and facilitate future deprecation.

@cccs-RyanK

TESTING INSTRUCTIONS

There are no functional changes. CI passing is sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #21445 (f4c13f5) into master (9c285da) will decrease coverage by 0.01%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master   #21445      +/-   ##
==========================================
- Coverage   66.53%   66.52%   -0.02%     
==========================================
  Files        1791     1792       +1     
  Lines       68599    68611      +12     
  Branches     7320     7327       +7     
==========================================
  Hits        45645    45645              
- Misses      21064    21076      +12     
  Partials     1890     1890              
Flag Coverage Δ
javascript 52.73% <41.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/SqlLab/components/QuerySearch/index.tsx 73.07% <ø> (ø)
...rset-frontend/src/components/AsyncSelect/index.jsx 90.00% <ø> (ø)
...c/components/DeprecatedSelect/DeprecatedSelect.tsx 53.33% <ø> (ø)
...d/src/components/DeprecatedSelect/NativeSelect.tsx 57.14% <ø> (ø)
.../src/components/DeprecatedSelect/OnPasteSelect.jsx 78.37% <ø> (ø)
...precatedSelect/WindowedSelect/WindowedMenuList.tsx 4.76% <ø> (ø)
...mponents/DeprecatedSelect/WindowedSelect/index.tsx 100.00% <ø> (ø)
...nents/DeprecatedSelect/WindowedSelect/windowed.tsx 72.72% <ø> (ø)
...rontend/src/components/DeprecatedSelect/styles.tsx 81.13% <ø> (ø)
superset-frontend/src/components/ListView/utils.ts 77.41% <ø> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 7c3fc67 into apache:master Sep 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants