-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(embedded): +2 functions: getDashboardPermalink, getActiveTabs #21444
Conversation
5728be4
to
7d87fab
Compare
44016a6
to
8b7b769
Compare
8b7b769
to
8691704
Compare
8691704
to
94db0a6
Compare
52edd4c
to
09ce85a
Compare
Codecov Report
@@ Coverage Diff @@
## master #21444 +/- ##
==========================================
+ Coverage 66.53% 66.61% +0.07%
==========================================
Files 1791 1796 +5
Lines 68599 68660 +61
Branches 7320 7314 -6
==========================================
+ Hits 45645 45738 +93
+ Misses 21064 21060 -4
+ Partials 1890 1862 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @jayakrishnankarolilnlsn, |
@Vitor-Avila , the changes looks completely unrelated. We should be fine here. What this is doing is enable the parent frame (app that embeds superset dashboard) that embeds the dashboard to call the embedded dashboard through message channel and get the dashboard permalink (apply all the filters and get a link) and also get the status of what is the active tab so that the parent app can do context aware activities. |
Ohh I see -- thank you so much for confirming it! |
Added 2 more functions in embedded superset: getDashboardPermalinkForAnchor, getActiveTabs
SUMMARY
Ability to request the following information from the parent app to embedded superset
TESTING INSTRUCTIONS
Embed dashboard using embedded sdk
Make calls to get active tabs
Make calls to get a chart permalink
ADDITIONAL INFORMATION