-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cypress runtime enhancements #21332
Conversation
…e/cypress-runtime-enhancements
Codecov Report
@@ Coverage Diff @@
## master #21332 +/- ##
==========================================
- Coverage 66.52% 66.50% -0.02%
==========================================
Files 1791 1791
Lines 68593 68593
Branches 7319 7319
==========================================
- Hits 45630 45619 -11
- Misses 21072 21083 +11
Partials 1891 1891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…e/cypress-runtime-enhancements
cy.get('[data-test="sort-header"]').eq(7).contains('Modified'); | ||
// TODO: this assert is flaky, we need to find a way to make it work consistenly | ||
// cy.get('[data-test="sort-header"]').eq(7).contains('Active'); | ||
// cy.get('[data-test="sort-header"]').eq(8).contains('Actions'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you fixed the Active
one. Is Actions
a lost cause, or should we leave the commented line in for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I think I just forgot to keep that comment. Cypress won't recognize that one. There is something weird going on with it. For now, I'll bring the comment back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
This PR is part of a tech debt initiative. It proposes several enhancements to the Cypress suite and runtime improvements, as follows:
This PR enhances the
dashboard
,dashboard list
,chart list
,dataset
,alerts_and_reports
anddatabase
suites.data-test
and provides utils such asgetBySel
_skip
prefix to those files that had all their tests skipped so that it is easier to spot themWHAT'S NEXT
_skip
files should be fixed and their tests enhanced following the new patternsexplore
,sqllab
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass and quicker
ADDITIONAL INFORMATION