-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade yeoman-generator to fix security warnings #21324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21324 +/- ##
==========================================
+ Coverage 66.47% 66.56% +0.08%
==========================================
Files 1789 1790 +1
Lines 68381 68391 +10
Branches 7276 7279 +3
==========================================
+ Hits 45455 45523 +68
+ Misses 21051 20991 -60
- Partials 1875 1877 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a bycatch comment
"superset", | ||
"yeoman-generator" | ||
], | ||
"homepage": "https://github.com/apache-superset/superset-ui#readme", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're here, maybe we want to move this to reference the apache/superset
repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! Good Catch!
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION