-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): sql editor's name has lost after reload #21246
fix(sqllab): sql editor's name has lost after reload #21246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21246 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 1784 1784
Lines 68163 68163
Branches 7264 7264
=======================================
Hits 45285 45285
Misses 21010 21010
Partials 1868 1868
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@lyndsiWilliams Ephemeral environment spinning up at http://54.68.173.23:8080. Credentials are |
Can we get additional testing from QA before merging? |
(cherry picked from commit ad6b98c)
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit ad6b98c)
SUMMARY
This bug was introduced by #20852
Since the editorQuery updates the title key by name but
PERSISTENT_QUERY_EDITOR_KEYS
hasn't updated, the queryEditor name value in localStorage has been discarded.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
cc: @lyndsiWilliams