-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add new e2e tests for Explore #21184
Conversation
@adam-stasiak Can you take a look? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Storybook has completed and can be viewed at |
Storybook has completed and can be viewed at |
Codecov Report
@@ Coverage Diff @@
## master #21184 +/- ##
==========================================
+ Coverage 66.29% 66.39% +0.10%
==========================================
Files 1773 1781 +8
Lines 67680 67893 +213
Branches 7214 7248 +34
==========================================
+ Hits 44866 45077 +211
+ Misses 20971 20954 -17
- Partials 1843 1862 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
||
cy.get( | ||
'.SouthPane .ant-tabs-content > .ant-tabs-tabpane-active > div button:first', | ||
{ timeout: 10000 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, what's the reason of this high timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes there was a small delay in rendering the component with buttons. Even though we wait for the query to finish, the test was flaky because cypress couldn't find the button because of that delay. A smaller timeout would probably work just as well though
Storybook has completed and can be viewed at |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION