-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(celery cache warmup): add auth and use warm_up_cache endpoint #21076
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21076 +/- ##
==========================================
- Coverage 66.28% 66.23% -0.06%
==========================================
Files 1770 1770
Lines 67522 67528 +6
Branches 7177 7177
==========================================
- Hits 44754 44724 -30
- Misses 20934 20970 +36
Partials 1834 1834
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bd797a5
to
e7f62e1
Compare
6cf8739
to
e233d65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rerunning CI |
UPDATE: I've recently discovered that the |
…ache#21076) (cherry picked from commit 04dd8d4)
We stopped using SUPERSET_WEBSERVER_PROTOCOL, ..._ADDRESS, ..._PORT with apache#21076. Removing the config from the example config as there does not seem to be any immediate need for it, we already have WEBDRIVER_BASEURL (and the _USER_FRIENDLY variant).
We stopped using SUPERSET_WEBSERVER_PROTOCOL, ..._ADDRESS, ..._PORT with apache#21076. Removing the config from the example config as there does not seem to be any immediate need for it, we already have WEBDRIVER_BASEURL (and the _USER_FRIENDLY variant).
SUMMARY
Fixes cache warmup via celery job.
THUMBNAIL_SELENIUM_USER
config for auth./superset/warm_up_cache
endpoint for warming up the cache.There is currently an open PR that addresses this issue, however it is using a web driver process to compute the warmup by visiting the dashboard which seems a bit process heavy. Since there is already a cache warmup endpoint that is able to handle charts and filters combos, it make more sense to use that endpoint.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
top_n_strategy
, set it to run at a high interval (for eg, every minute). documented hereADDITIONAL INFORMATION