feat: add tableselector to dataset creation page #21075

pkdotson · 2022-08-12T16:36:10Z

SUMMARY

This pr adds the database selector to the leftpanel for the new dataset creation page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…eat-add-tableselector

github-actions · 2022-08-24T19:06:02Z

Storybook has completed and can be viewed at

lyndsiWilliams

Found a few nits, mostly theming/TS 😁

superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx

github-actions · 2022-08-25T03:07:50Z

Storybook has completed and can be viewed at

superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx

AAfghahi · 2022-08-25T14:43:01Z

superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx

@@ -63,14 +64,22 @@ export function datasetReducer(
 export default function AddDataset() {
  // this is commented out for now, but can be commented in as the component


we can delete this comment now that we are actually using the reducer :)

+1 on this, remove the "this is commented out for now..." comment

AAfghahi · 2022-08-25T14:44:51Z

This looks really nice. Put in a couple of thoughts, one question though re: spacing. The padding in the table section looks a bit wonky, is that what it was on the figma?

…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <[email protected]>

github-actions · 2022-08-25T22:54:07Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T22:56:58Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T22:59:58Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T23:02:21Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T23:04:05Z

Storybook has completed and can be viewed at

…eat-add-tableselector

codecov · 2022-08-30T10:16:02Z

Codecov Report

Merging #21075 (8a92b3e) into master (286474c) will increase coverage by 0.02%.
The diff coverage is 84.74%.

@@            Coverage Diff             @@
##           master   #21075      +/-   ##
==========================================
+ Coverage   66.58%   66.60%   +0.02%     
==========================================
  Files        1790     1790              
  Lines       68416    68478      +62     
  Branches     7287     7298      +11     
==========================================
+ Hits        45554    45610      +56     
- Misses      20986    20990       +4     
- Partials     1876     1878       +2

Flag	Coverage Δ
javascript	`52.78% <84.74%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx	`83.92% <83.63%> (-16.08%)`	⬇️
...et-frontend/src/components/TableSelector/index.tsx	`76.00% <100.00%> (ø)`
...d/src/views/CRUD/data/dataset/AddDataset/index.tsx	`33.33% <100.00%> (+22.22%)`	⬆️
...trols/DateFilterControl/components/CustomFrame.tsx	`70.96% <0.00%> (-1.45%)`	⬇️
...ents/controls/DateFilterControl/utils/constants.ts	`100.00% <0.00%> (ø)`
...taTablesPane/components/ResultsPaneOnDashboard.tsx	`100.00% <0.00%> (ø)`
...frontend/src/components/DatabaseSelector/index.tsx	`95.23% <0.00%> (+6.34%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AAfghahi · 2022-08-30T14:47:09Z

/testenv up

github-actions · 2022-08-30T16:11:46Z

@AAfghahi Ephemeral environment spinning up at http://52.32.56.113:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

lyndsiWilliams

I found a few more things, let me know if you have any questions! 😁

superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx

superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx

lyndsiWilliams · 2022-08-30T17:28:31Z

superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx

@@ -63,14 +64,22 @@ export function datasetReducer(
 export default function AddDataset() {
  // this is commented out for now, but can be commented in as the component


+1 on this, remove the "this is commented out for now..." comment

superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx

superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx

superset-frontend/src/views/CRUD/data/dataset/AddDataset/types.tsx

yousoph · 2022-09-01T20:39:37Z

/testenv up

github-actions · 2022-09-01T20:44:16Z

@yousoph Ephemeral environment spinning up at http://54.218.74.130:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

…eat-add-tableselector

github-actions · 2022-09-07T21:08:42Z

Ephemeral environment shutdown and build artifacts deleted.

pkdotson added 4 commits August 5, 2022 11:49

add database selector

85bcbca

add schema util

cd87fda

add pagination

413aea9

remove conosle.logs

aeb0d6f

pull-request-size bot added the size/L label Aug 12, 2022

pkdotson added 5 commits August 18, 2022 06:58

add search

0f0ded9

remove logs

7e1ca34

Merge branch 'master' of https://github.com/preset-io/superset into f…

96b609a

…eat-add-tableselector

more updates

3bbe070

update loading style and add state

23e03b1

pkdotson changed the title ~~feat(WIP): add tableselector to dataset creation page~~ feat: add tableselector to dataset creation page Aug 24, 2022

pkdotson marked this pull request as ready for review August 24, 2022 23:06

lyndsiWilliams reviewed Aug 24, 2022

View reviewed changes

remove header styles

b0cf236

AAfghahi reviewed Aug 25, 2022

View reviewed changes

pkdotson and others added 7 commits August 25, 2022 15:46

add test, fix types, other updates

3c680b5

Update superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftP…

8e5d195

…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <[email protected]>

Update superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftP…

1ffcf86

…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <[email protected]>

Update superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftP…

b7fb96d

…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <[email protected]>

Update superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftP…

2fbc0b1

…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <[email protected]>

Update superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftP…

d982996

…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <[email protected]>

Update superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftP…

16ae23b

…anel/index.tsx Co-authored-by: Lyndsi Kay Williams <[email protected]>

pkdotson added 5 commits August 29, 2022 13:55

Merge branch 'master' of https://github.com/preset-io/superset into f…

d3ed28e

…eat-add-tableselector

update type

48b15b2

fix tests

ee25dc7

fix test

a4258ba

run precommit

4ce4d29

AAfghahi approved these changes Aug 30, 2022

View reviewed changes

lyndsiWilliams reviewed Aug 30, 2022

View reviewed changes

pkdotson added 3 commits August 30, 2022 22:10

add suggestions

a02db58

match styles and desgin

1689774

update test

b169378

pull-request-size bot added size/XL and removed size/L labels Sep 1, 2022

pkdotson added 6 commits September 6, 2022 13:39

update test and last changes

2012690

Merge branch 'master' of https://github.com/preset-io/superset into f…

9745842

…eat-add-tableselector

fix merge

e81484f

fix indentation

f0dd386

remove log

4057c66

fix parent component tests

8a92b3e

pkdotson merged commit 8c2719b into apache:master Sep 7, 2022

john-bodley mentioned this pull request Sep 14, 2022

fix: Address regression introduced in #21284 #21470

Merged

9 tasks

mistercrunch added the 🚢 2.1.3 label Feb 18, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add tableselector to dataset creation page #21075

feat: add tableselector to dataset creation page #21075

pkdotson commented Aug 12, 2022 •

edited

Loading

github-actions bot commented Aug 24, 2022

lyndsiWilliams left a comment

github-actions bot commented Aug 25, 2022

AAfghahi Aug 25, 2022

lyndsiWilliams Aug 30, 2022

AAfghahi commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

codecov bot commented Aug 30, 2022 •

edited

Loading

AAfghahi commented Aug 30, 2022

github-actions bot commented Aug 30, 2022

lyndsiWilliams left a comment

lyndsiWilliams Aug 30, 2022

yousoph commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 7, 2022

		@@ -63,14 +64,22 @@ export function datasetReducer(
		export default function AddDataset() {
		// this is commented out for now, but can be commented in as the component

feat: add tableselector to dataset creation page #21075

feat: add tableselector to dataset creation page #21075

Conversation

pkdotson commented Aug 12, 2022 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

github-actions bot commented Aug 24, 2022

lyndsiWilliams left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 25, 2022

AAfghahi Aug 25, 2022

Choose a reason for hiding this comment

lyndsiWilliams Aug 30, 2022

Choose a reason for hiding this comment

AAfghahi commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

codecov bot commented Aug 30, 2022 • edited Loading

Codecov Report

AAfghahi commented Aug 30, 2022

github-actions bot commented Aug 30, 2022

lyndsiWilliams left a comment

Choose a reason for hiding this comment

lyndsiWilliams Aug 30, 2022

Choose a reason for hiding this comment

yousoph commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 7, 2022

pkdotson commented Aug 12, 2022 •

edited

Loading

codecov bot commented Aug 30, 2022 •

edited

Loading