-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(charts): Hide Values greater than Max Y Axis Bound on Mixed Time Series with Bar series #21015
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21015 +/- ##
==========================================
- Coverage 66.27% 66.27% -0.01%
==========================================
Files 1770 1770
Lines 67530 67555 +25
Branches 7182 7191 +9
==========================================
+ Hits 44758 44770 +12
- Misses 20936 20945 +9
- Partials 1836 1840 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
Outdated
Show resolved
Hide resolved
644a299
to
017ab66
Compare
- When Bar chart is used as serie type, we need to hide values that are greater than the max Y Axis Bound.
- Simplify logic for getOverMaxHiddenFormatter
- Add tests for new getOverMaxHiddenFormatter util func
017ab66
to
6e407d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION