Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-echarts): gauge chart enhancements and fixes #21007

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Aug 7, 2022

SUMMARY

This PR improves the gauge chart:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-08-08.12.39.21.mov

after

2022-08-08.12.38.13.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #21007 (4317e92) into master (e214e1a) will increase coverage by 0.00%.
The diff coverage is 75.60%.

❗ Current head 4317e92 differs from pull request most recent head 73e98d5. Consider uploading reports for the commit 73e98d5 to get more accurate results

@@           Coverage Diff           @@
##           master   #21007   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files        1767     1767           
  Lines       67312    67344   +32     
  Branches     7144     7146    +2     
=======================================
+ Hits        44656    44681   +25     
- Misses      20828    20833    +5     
- Partials     1828     1830    +2     
Flag Coverage Δ
javascript 52.11% <57.89%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 66.66% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/types.ts 100.00% <ø> (ø)
...s/plugin-chart-echarts/src/Gauge/transformProps.ts 76.92% <57.89%> (-4.90%) ⬇️
superset/views/datasource/utils.py 93.33% <66.66%> (-2.02%) ⬇️
superset/common/query_actions.py 92.39% <92.85%> (+0.08%) ⬆️
superset/common/chart_data.py 100.00% <100.00%> (ø)
superset/views/datasource/schemas.py 100.00% <100.00%> (ø)
superset/db_engine_specs/mysql.py 98.80% <0.00%> (+1.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yousoph
Copy link
Member

yousoph commented Aug 11, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.86.138.180:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit b303d1e into apache:master Aug 16, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

eschutho pushed a commit that referenced this pull request Sep 20, 2022
* fix(plugin-chart-echarts): gauge chart enhancements and fixes

* fix lint

(cherry picked from commit b303d1e)
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
…#21007)

* fix(plugin-chart-echarts): gauge chart enhancements and fixes

* fix lint

(cherry picked from commit b303d1e)
@mistercrunch mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.0 v2.0.1 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants