-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use SPA Dataset link in Chart and Dashboard #20941
fix: Use SPA Dataset link in Chart and Dashboard #20941
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20941 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 1766 1766
Lines 67224 67225 +1
Branches 7135 7136 +1
=======================================
+ Hits 44625 44626 +1
Misses 20774 20774
Partials 1825 1825
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
superset-frontend/src/dashboard/components/AddSliceCard/AddSliceCard.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, well spotted!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the improvement @EugeneTorap!
I've just merged a fix for this failing test on CI. If you pull from master your CI should pass 😁 |
Done @michael-s-molina Can we merge the PR? |
Improve #20890 PR logic and use dataset links in SPA in Chart and Dashboard
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
@michael-s-molina @kgabryje