Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add databricks logo #20849

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Jul 25, 2022

Added Databricks logo to Docs

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #20849 (f9a0cdc) into master (644148b) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head f9a0cdc differs from pull request most recent head d2add55. Consider uploading reports for the commit d2add55 to get more accurate results

@@            Coverage Diff             @@
##           master   #20849      +/-   ##
==========================================
- Coverage   66.33%   66.29%   -0.04%     
==========================================
  Files        1756     1757       +1     
  Lines       66769    66867      +98     
  Branches     7059     7077      +18     
==========================================
+ Hits        44288    44332      +44     
- Misses      20684    20726      +42     
- Partials     1797     1809      +12     
Flag Coverage Δ
javascript 51.95% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/dashboard/util/activeAllDashboardFilters.ts 60.00% <0.00%> (-26.96%) ⬇️
...shboard/util/charts/getFormDataWithExtraFilters.ts 88.88% <0.00%> (-5.56%) ⬇️
...perset-ui-core/src/chart/components/SuperChart.tsx 97.22% <0.00%> (-2.78%) ⬇️
...rossFilterScopingModal/CrossFilterScopingModal.tsx 78.57% <0.00%> (-1.43%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.14% <0.00%> (-0.44%) ⬇️
superset-frontend/src/dashboard/actions/hydrate.js 1.96% <0.00%> (-0.11%) ⬇️
superset-frontend/src/explore/ExplorePage.tsx 0.00% <0.00%> (ø)
superset-frontend/src/utils/localStorageHelpers.ts 90.00% <0.00%> (ø)
...perset-frontend/src/dashboard/containers/Chart.jsx 75.00% <0.00%> (ø)
...nd/src/dashboard/components/nativeFilters/utils.ts 46.66% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@@ -91,6 +91,7 @@ Here are some of the major database solutions that are supported:
<img src="superset-frontend/src/assets/images/snowflake.png" alt="snowflake" border="0" width="152" height="46"/>
<img src="superset-frontend/src/assets/images/trino.png" alt="trino" border="0" width="46" height="46"/>
<img src="superset-frontend/src/assets/images/presto.png" alt="presto" border="0" width="152" height="46"/>
<img src="superset-frontend/src/assets/images/databricks.png" alt="druid" border="0" width="142" height="22" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="superset-frontend/src/assets/images/databricks.png" alt="druid" border="0" width="142" height="22" />
<img src="superset-frontend/src/assets/images/databricks.png" alt="databricks" border="0" width="142" height="22" />

@srinify srinify merged commit c4564a9 into apache:master Jul 25, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants