Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add complex type to pydruid #20834

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Jul 22, 2022

SUMMARY

Monkeypatch pydruid to support the "complex" column type.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2022-07-25 at 08-39-16 Superset

TESTING INSTRUCTIONS

I loaded a druid dataset with a column of type HLLSketchBuild, and verified it works (see screenshot).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #20834 (bddcd32) into master (2263a76) will decrease coverage by 0.16%.
The diff coverage is 25.00%.

❗ Current head bddcd32 differs from pull request most recent head c3a834e. Consider uploading reports for the commit c3a834e to get more accurate results

@@            Coverage Diff             @@
##           master   #20834      +/-   ##
==========================================
- Coverage   66.32%   66.16%   -0.17%     
==========================================
  Files        1756     1756              
  Lines       66767    66769       +2     
  Branches     7060     7060              
==========================================
- Hits        44286    44179     -107     
- Misses      20683    20792     +109     
  Partials     1798     1798              
Flag Coverage Δ
hive ?
mysql 81.07% <42.10%> (+0.01%) ⬆️
postgres 81.14% <42.10%> (+0.01%) ⬆️
presto ?
python 81.24% <42.10%> (-0.34%) ⬇️
sqlite 79.76% <42.10%> (+0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts 84.40% <ø> (ø)
...et-frontend/src/components/EditableTitle/index.tsx 64.28% <ø> (ø)
...rossFilterScopingModal/CrossFilterScopingModal.tsx 80.00% <0.00%> (ø)
...src/dashboard/components/FiltersBadge/selectors.ts 68.46% <0.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 60.58% <0.00%> (ø)
...nd/src/dashboard/components/nativeFilters/utils.ts 46.66% <ø> (ø)
...perset-frontend/src/dashboard/containers/Chart.jsx 75.00% <ø> (ø)
...set-frontend/src/dashboard/containers/Dashboard.ts 0.00% <ø> (ø)
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick fix!

@betodealmeida betodealmeida force-pushed the complex_type_pydruid branch from 201cd61 to 9754b2f Compare July 25, 2022 15:46
@betodealmeida
Copy link
Member Author

I also fixed this upstream: druid-io/pydruid#290

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Jul 25, 2022
@betodealmeida betodealmeida merged commit 672266c into apache:master Jul 25, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.29

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 25, 2022
* fix: add complex type to pydruid

* Kick jobs

(cherry picked from commit 672266c)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset:2022.29 size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants