Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore Applitools by default when running Cypress tests #20789

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

geido
Copy link
Member

@geido geido commented Jul 20, 2022

SUMMARY

This PR ignores Applitools related tests when running Cypress and runs Applitools tests only when specifically required in the Github workflow.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

Make sure all the cypress tests are running normally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #20789 (1bed037) into master (932e304) will decrease coverage by 0.43%.
The diff coverage is 62.27%.

@@            Coverage Diff             @@
##           master   #20789      +/-   ##
==========================================
- Coverage   66.81%   66.38%   -0.44%     
==========================================
  Files        1752     1762      +10     
  Lines       65478    67261    +1783     
  Branches     6916     7232     +316     
==========================================
+ Hits        43750    44649     +899     
- Misses      19980    20792     +812     
- Partials     1748     1820      +72     
Flag Coverage Δ
hive 53.27% <ø> (-0.49%) ⬇️
javascript 52.25% <61.79%> (+0.45%) ⬆️
mysql 81.04% <ø> (-1.33%) ⬇️
postgres 81.11% <ø> (-1.33%) ⬇️
presto 53.13% <ø> (-0.49%) ⬇️
python 81.56% <ø> (-1.32%) ⬇️
sqlite 79.60% <ø> (-2.62%) ⬇️
unit 50.28% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/superset-ui-chart-controls/src/constants.ts 100.00% <ø> (ø)
...t-ui-chart-controls/src/operators/pivotOperator.ts 100.00% <ø> (ø)
...controls/src/operators/timeComparePivotOperator.ts 100.00% <ø> (ø)
...art-controls/src/sections/annotationsAndLayers.tsx 100.00% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 50.00% <ø> (ø)
...perset-ui-chart-controls/src/sections/sections.tsx 100.00% <ø> (ø)
...i-chart-controls/src/shared-controls/constants.tsx 18.75% <0.00%> (-18.75%) ⬇️
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts 100.00% <ø> (ø)
...ges/superset-ui-core/src/query/extractTimegrain.ts 100.00% <ø> (ø)
... and 326 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@geido geido merged commit 76f573a into master Jul 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/update-cypress-test-local branch March 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants