fix: "Refresh Dashboard" only refreshes active tab #20688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
On a tabbed dashboard, “refresh dashboard” only refreshes the active tab.
Due to performance, charts are not rerendered if their visibility changes, so when switching tabs, you'll get the old values back.
This PR allows the rerendering of the chart if the status changed from the loading status.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
old.mov
After:
new.mov
TESTING INSTRUCTIONS
Select 1 as "Test"
When you load the dashboard and open the tab from the first time, it should show the value correctly.
Select 2 as "Test"
The chart should display the updated data.
ADDITIONAL INFORMATION