fix: Change dataset name affect data access role set to this dataset #20574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the user changes the name of a virtual dataset, any user that had specific access to said dataset will no longer be able to access it.
The issue is because the
set_perm
function is changing the table name but not the permission and view_model, thus, a new permission/view is created and the users keep pointing to the old one.This PR ensures that, on name change, those records are also updated.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-06-30.at.18.18.17.mov
After:
new.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION