Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SqlLab): Change Save Dataset Button to Split Save Query Button II #20570

Closed
wants to merge 90 commits into from
Closed

feat(SqlLab): Change Save Dataset Button to Split Save Query Button II #20570

wants to merge 90 commits into from

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This changes the current save query button into a split save button if the database has "Allow this database to be explored" enabled. When the user clicks the caret section of the button, they can now save the query as a dataset.

Bonus: In order to create this button, I conveniently needed to fix the styling on the "Run" query split button. The split line now goes all the way through the button and the caret is centered.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

saveButtonBefore
runButtonBefore

AFTER:

splitSaveButtonAfter
saveButtonAfter
runButtonAfter

TESTING INSTRUCTIONS

  • From SqlLab, open a query for a database that has "Allow this database to be explored" enabled.
    • Observe the new split save button
      • Click the "Save" section of the button to see the save query modal
      • Click the caret v section of the button, then click "Save dataset" to see the save dataset modal
      • Both of these modals should be fully functional
  • From SqlLab, open a query for a database that does NOT have "Allow this database to be explored" enabled.
    • Observe that the save button is a normal button, not split
      • Clicking this button should show the save query modal

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

hughhhh and others added 30 commits June 6, 2022 15:09
@hughhhh
add POC ExploreMixin
6fc435d
@hughhhh
Working POC
632ce21 
> columns are loading into page
@lyndsiWilliams
Created/tested query dataset dropdown
6f22618
@lyndsiWilliams
Add isValidDatasourceType to @superset-ui/core and hide query dropdown
236c489
@hughhhh
fix merge conflicts
24261d1
@lyndsiWilliams
Visual updates to explore datasource panel
bd3b6a9
@lyndsiWilliams
Temporarily make Query icon visible
64f4181
@lyndsiWilliams
Remove Query icon visibility
7c07534
@lyndsiWilliams
Removed isValidDatasourceType check
6fab57f
@eric-briscoe
Added Query preview Modal from DatasourceControl if the data source t…
3a46152 
…ype is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component
@hughhhh
> fix integration point with frontend
613d78a 
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working
@hughhhh
Merge branch 'master' of https://github.com/preset-io/superset into c…
e076f13 
…hart-power-query
@eric-briscoe
Adjusts conditional logic approach to be extensible for additional ty…
31dfdd2 
…pes from DatasourceTypes options
@eric-briscoe
Merge branch 'chart-power-query' into lyndsi/dataset-panel-updates
bbb91e0
@eric-briscoe
Merge branch 'lyndsi/dataset-panel-updates' into ericbriscoe/sc-41493…
8513cc5 
…/query-preview-modal-for-chart-source-query
@hughhhh
refactor
cd54603
@hughhhh
Merge branch 'master' of https://github.com/preset-io/superset into c…
a173cfa 
…hart-power-query
@eric-briscoe
Merge pull request #218 from preset-io/ericbriscoe/sc-41493/query-pre…
0295818 
…view-modal-for-chart-source-query

feat: Ericbriscoe/sc 41493/query preview modal for chart source query
@hughhhh
set field for sql
de20276
@eric-briscoe
Fixes issue where Missing query parameters error was showing in datas…
bd7db0d 
…ourcePanel
@hughhhh
add query_language
e344197
@hughhhh
fix ds main_dttm
9c5bc48
@eric-briscoe
Fixes issue where menu.tsx was blocking access to redux debugging for…
b6fbc33 
… SqlLab and Explore
@eric-briscoe
Fixes issue where database id was not available to save query as data…
6af2961 
…set, adds default metric when chart source is query
@eric-briscoe
Merge branch 'master' into chart-power-query
12546f5
@hughhhh
Merge branch 'master' into chart-power-query
ff59846
@hughhhh
oops
bdbf2d1
@hughhhh
fix pre-commit to 50 errors now
559e1a2
@hughhhh
fix circuliar dep
890be43
@eric-briscoe
Disables showing Metrics section in DatasourcePanel when Query is the…
4b833be 
… datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type
hughhhh and others added 20 commits July 8, 2022 13:50
@hughhhh
fix exceptions
661bb9e
@hughhhh
fix fe lint
b476b70
@hughhhh
fix test
56fcdc9
@hughhhh
Merge pull request #233 from preset-io/chart-power-query-samples
551ddc8 
fix: Move chart samples to explore resource endpoint
@hughhhh
add tab_name to payload
6e5443a
@eric-briscoe
Enables use of tab name from Query
97ac731
@hughhhh
fix merge conflicts
664773a
@hughhhh
fix cypress test
a073313
@hughhhh
save columns on execution
f717e18
@hughhhh
fix frontend build test
16ea687
@hughhhh
remove parathesis around columns
3f6fa0a
@lyndsiWilliams
Created split save button and added save as dataset functionality
442d661
@lyndsiWilliams
Added testing and converted SaveQuery test to RTL
cfb73ab
@lyndsiWilliams
Fix button styling issue
ca58494
@eschutho @lyndsiWilliams
add more specificity
3239f83
@lyndsiWilliams
Trying for more specificity
e55793f
@lyndsiWilliams
Fix SaveQuery test
5ba0053
@lyndsiWilliams
Fix font weight on split save button
fd16344
@lyndsiWilliams
Move styles back into styled component
507db9b
@lyndsiWilliams
Change QueryEditor title property to name
cd89138
@lyndsiWilliams lyndsiWilliams force-pushed the lyndsi/sql-lab-new-explore-button-functionality-and-move-save-dataset-to-split-save-button branch from 21455d5 to cd89138 Compare July 11, 2022 16:01
@lyndsiWilliams
Copy link
Member Author

Continued in this PR: #20852

@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@lyndsiWilliams lyndsiWilliams deleted the lyndsi/sql-lab-new-explore-button-functionality-and-move-save-dataset-to-split-save-button branch July 28, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho left review comments

Assignees
No one assigned
Labels
preset-io size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lyndsiWilliams @eschutho @hughhhh @eric-briscoe @AAfghahi