fix: Re-add filter-box time granularity/column #20485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Jun 23, 2022
| type: 'CheckboxControl', | ||
| label: t('Show time grain dropdown'), | ||
| default: false, | ||
| description: t('Check to include time grain dropdown'), |
There was a problem hiding this comment.
Per here I think the old labels where mixed, i.e., if Druid was enabled it would include the term SQL. I opted for the clearer labels/description.
Codecov Report
@@ Coverage Diff @@
## master #20485 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 1740 1740
Lines 65156 65156
Branches 6900 6900
=======================================
Hits 43492 43492
Misses 19915 19915
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jun 23, 2022
Co-authored-by: John Bodley <[email protected]> (cherry picked from commit 661ab35)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 28, 2022
Co-authored-by: John Bodley <[email protected]> (cherry picked from commit 661ab35)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 28, 2022
Co-authored-by: John Bodley <[email protected]> (cherry picked from commit 661ab35)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 6, 2022
Co-authored-by: John Bodley <[email protected]> (cherry picked from commit 661ab35)
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a regression in #19770 which accidentally removed several SQL controls from the filter-box visualization.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
Tested locally and verified (per the screenshots) that the missing SQL controls were re-added.
ADDITIONAL INFORMATION