You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error message when user tries to import without having db driver installed
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
Import a file (dashboard, chart, dataset, database) that contains a database where the user doesn't have the database driver installed
Current behavior:
The db driver is installed and the error has nothing to do with the database, so the user getting this error text doesn't make sense.
Expected behavior:
User sees an error message when they don't have the db driver installed
ADDITIONAL INFORMATION
Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
Migration is atomic, supports rollback & is backwards-compatible
Confirm DB migration upgrade and downgrade tested
Runtime estimates and downtime expectations provided
Merging #20442 (5fff274) into master (b7eb235) will decrease coverage by 0.00%.
The diff coverage is 33.33%.
❗ Current head 5fff274 differs from pull request most recent head fd81271. Consider uploading reports for the commit fd81271 to get more accurate results
@yousoph Ephemeral environment spinning up at http://34.221.18.69:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.
…led and error is existed while importing file. (#20442)
* fix(db): make to show the db error msg when db installed and error is exist
* fix(db): make to replace dbinstall str into showDbInstallInstructions
(cherry picked from commit 23e62d3)
…led and error is existed while importing file. (#20442)
* fix(db): make to show the db error msg when db installed and error is exist
* fix(db): make to replace dbinstall str into showDbInstallInstructions
(cherry picked from commit 23e62d3)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mistercrunch
added
🏷️ bot
SUMMARY
Add error message when user tries to import without having db driver installed
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
Import a file (dashboard, chart, dataset, database) that contains a database where the user doesn't have the database driver installed
Current behavior:
The db driver is installed and the error has nothing to do with the database, so the user getting this error text doesn't make sense.
Expected behavior:
User sees an error message when they don't have the db driver installed
ADDITIONAL INFORMATION