-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fonts): Show the all the A's in our workspace correctly, not funky #20361
Conversation
@@ -80,7 +80,7 @@ | |||
"@emotion/cache": "^11.4.0", | |||
"@emotion/react": "^11.4.1", | |||
"@emotion/styled": "^11.3.0", | |||
"@fontsource/inter": "^4.5.7", | |||
"@fontsource/inter": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what caused the issue with the previous version of the lib?
Did you try the latest version too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sure, it also gives issues with latest version and so I downgrade it into 4.0.0 version from this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Does the bug also occur with monospace font?
Not that we've seen. I think it's specifically an Inter issue. |
I believe that it doesn't make the issue with monospace font. |
Codecov Report
@@ Coverage Diff @@
## master #20361 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 1739 1739
Lines 65143 65143
Branches 6902 6902
=======================================
Hits 43443 43443
Misses 19947 19947
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
SUMMARY
All the A's in our workspace buttons look funky
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION