Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fonts): Show the all the A's in our workspace correctly, not funky #20361

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Jun 13, 2022

SUMMARY

All the A's in our workspace buttons look funky

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

  1. Go to the Welcome page
  2. You can show that the A's looks funky there.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -80,7 +80,7 @@
"@emotion/cache": "^11.4.0",
"@emotion/react": "^11.4.1",
"@emotion/styled": "^11.3.0",
"@fontsource/inter": "^4.5.7",
"@fontsource/inter": "^4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what caused the issue with the previous version of the lib?
Did you try the latest version too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure, it also gives issues with latest version and so I downgrade it into 4.0.0 version from this PR

@rusackas rusackas requested a review from kgabryje June 13, 2022 20:37
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does the bug also occur with monospace font?

@rusackas rusackas closed this Jun 14, 2022
@rusackas rusackas reopened this Jun 14, 2022
@rusackas
Copy link
Member

Nice! Does the bug also occur with monospace font?

Not that we've seen. I think it's specifically an Inter issue.

@prosdev0107
Copy link
Contributor Author

I believe that it doesn't make the issue with monospace font.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #20361 (9397610) into master (160e674) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20361   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files        1739     1739           
  Lines       65143    65143           
  Branches     6902     6902           
=======================================
  Hits        43443    43443           
  Misses      19947    19947           
  Partials     1753     1753           
Flag Coverage Δ
javascript 51.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 160e674...9397610. Read the comment docs.

@rusackas rusackas merged commit df8bb46 into apache:master Jun 15, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants