Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes embedded/index.tsx warnings #20193

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Replaces console invocations with logging from @superset-ui/core
  • Moves the showFailureMessage function to avoid the was used before it was defined warning

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #20193 (19d1dd5) into master (4674de1) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 19d1dd5 differs from pull request most recent head 7c2f2e4. Consider uploading reports for the commit 7c2f2e4 to get more accurate results

@@            Coverage Diff             @@
##           master   #20193      +/-   ##
==========================================
- Coverage   66.32%   66.26%   -0.06%     
==========================================
  Files        1722     1722              
  Lines       64639    64639              
  Branches     6822     6822              
==========================================
- Hits        42874    42836      -38     
- Misses      20031    20069      +38     
  Partials     1734     1734              
Flag Coverage Δ
javascript 51.29% <0.00%> (ø)
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
superset/db_engine_specs/presto.py 83.36% <0.00%> (-5.34%) ⬇️
superset/connectors/sqla/models.py 88.41% <0.00%> (-1.01%) ⬇️
superset/models/core.py 88.91% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4674de1...7c2f2e4. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 73443ce into apache:master May 25, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants