-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(db): make to allow to show/hide the password when only creating #20186
fix(db): make to allow to show/hide the password when only creating #20186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20186 +/- ##
==========================================
- Coverage 66.44% 66.42% -0.03%
==========================================
Files 1721 1721
Lines 64548 64581 +33
Branches 6811 6821 +10
==========================================
+ Hits 42890 42899 +9
- Misses 19925 19949 +24
Partials 1733 1733
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@yousoph Ephemeral environment spinning up at http://18.237.178.236:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tested a bit on the ephemeral, looking good to me also |
Ephemeral environment shutdown and build artifacts deleted. |
…pache#20186) (cherry picked from commit 95b28fc)
🏷️ preset:2022.21 |
SUMMARY
Show/Hide Password in Database Connection Creation Dynamic Forms
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce issues
The relevant forms that this should impact:
Postgres
MySQL
Snowflake
Redshift
ADDITIONAL INFORMATION