-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: advanced data type API spec and permission name #20128
fix: advanced data type API spec and permission name #20128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this improvement! FYI @cccs-RyanS
Codecov Report
@@ Coverage Diff @@
## master #20128 +/- ##
==========================================
- Coverage 66.47% 66.28% -0.19%
==========================================
Files 1721 1721
Lines 64477 64481 +4
Branches 6795 6795
==========================================
- Hits 42858 42743 -115
- Misses 19891 20010 +119
Partials 1728 1728
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -96,15 +90,9 @@ def get(self, **kwargs: Any) -> Response: | |||
500: | |||
$ref: '#/components/responses/500' | |||
""" | |||
items = kwargs["rison"] | |||
advanced_data_type = items.get("type") | |||
if not advanced_data_type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rison automatically parses the query string from the defined json schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
* fix: advanced data type API spec and permission name * fix openAPI spec * fix query schema * fix query schema * fix query schema
SUMMARY
Simple fix for the new advanced type REST API, we currently use
can_read
permissions instead of FAB defaultcan_get
also simplified the OpenAPI spec and added the rison schema to the decorator so that JSON schema will actually be evaluated
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION