fix(presto,trino): use correct literal dttm separator #20123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20123 +/- ##
==========================================
- Coverage 66.46% 66.44% -0.03%
==========================================
Files 1721 1721
Lines 64467 64477 +10
Branches 6795 6795
==========================================
- Hits 42847 42839 -8
- Misses 19892 19910 +18
Partials 1728 1728
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
approved these changes
May 19, 2022
Good point, let me check and add Athena, too. |
|
Turns out Athena was already using the space separator, so going to go ahead and merge this. |
villebro
added a commit
that referenced
this pull request
May 26, 2022
* fix(presto,trino): use correct literal dttm separator * remove redundant tests (cherry picked from commit e2f11d3)
michael-s-molina
pushed a commit
that referenced
this pull request
May 26, 2022
* fix(presto,trino): use correct literal dttm separator * remove redundant tests (cherry picked from commit e2f11d3)
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* fix(presto,trino): use correct literal dttm separator * remove redundant tests
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jun 16, 2022
* fix(presto,trino): use correct literal dttm separator * remove redundant tests (cherry picked from commit e2f11d3)
mistercrunch
added
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#19917 migrated the
convert_dttmfunctions in the Presto and Trino db engine specs to use the currently recommended literal timestamp type cast over the now deprecatedfrom_iso8601_*functions. However, the new literal casts require the separator to be a blank space instead of the "T" separator:This PR updates the format to correspond with the supported format and updates the unit tests accordingly. In addition, the
convert_dttmtests are removed from the legacy integration test suite, as they're already covered by the new unit tests.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION