Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart & gallery): make to add mixed time-series into recommended charts #20064

Merged
merged 1 commit into from
May 14, 2022

Conversation

prosdev0107
Copy link
Contributor

SUMMARY

[Gallery] Mixed time series chart should have advanced-analytics tag

Expected results
mixed time series chart has advanced analytics tag, this is a new feature that we add for this release

Actual results
mixed time series chart do not have advanced analytics tag

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

Repro steps
1, add new chart and go to chart gallery
2, select Advanced analytics tag and look for mixed time series chart

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #20064 (1eb144c) into master (3043a54) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20064   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        1715     1715           
  Lines       64169    64186   +17     
  Branches     6748     6753    +5     
=======================================
+ Hits        42584    42597   +13     
- Misses      19868    19871    +3     
- Partials     1717     1718    +1     
Flag Coverage Δ
javascript 51.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-echarts/src/MixedTimeseries/index.ts 50.00% <ø> (ø)
...ponents/controls/ControlPopover/ControlPopover.tsx 89.09% <0.00%> (-0.66%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.33% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3043a54...1eb144c. Read the comment docs.

@stephenLYZ
Copy link
Member

LGTM!

@stephenLYZ stephenLYZ merged commit f43dbc0 into apache:master May 14, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants