-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hack db connection modal ctabtns #20017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20017 +/- ##
==========================================
+ Coverage 66.35% 66.44% +0.08%
==========================================
Files 1712 1740 +28
Lines 64056 64848 +792
Branches 6741 6938 +197
==========================================
+ Hits 42504 43086 +582
- Misses 19841 20004 +163
- Partials 1711 1758 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@yousoph Ephemeral environment spinning up at http://34.218.80.71:8080. Credentials are |
@jess-dillard can you see if the styling on the second step of the db connection screen looks good to you? |
Ephemeral environment shutdown and build artifacts deleted. |
* add flow for dbconnmodal to datasetmodal * fix bug * second part * fix dataset to sql lab * fix lint * more lint * add key value * fix type * add new styling * remove undefined from types
SUMMARY
This pr creates two cta buttons to create dataset or to go to sqllab in the db connection modal after a user connects their db
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
Screen.Recording.2022-05-11.at.1.21.32.PM.mov
TESTING INSTRUCTIONS
Go to database connection modal and connect a db. There should be two cta button that take you to create dataset or to sql lab.
ADDITIONAL INFORMATION