fix: Athena timestamp literal format #19970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinhnd2104
changed the title
Update test
|
Pinged for some reviews. Thanks for the contribution! |
|
@thinhnd2104 do you mind addressing the failed CI checks? |
Thank you. This commit was updated. |
Codecov Report
@@ Coverage Diff @@
## master #19970 +/- ##
=======================================
Coverage 66.37% 66.37%
=======================================
Files 1715 1715
Lines 64179 64179
Branches 6753 6753
=======================================
Hits 42602 42602
Misses 19859 19859
Partials 1718 1718
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@thinhnd2104 I pushed a commit to fix the linting error and will merge once CI passes. |
|
Thank you! |
|
@thinhnd2104 thanks again for the fix; I'm tagging this for 1.5.1 which I'm hoping we'll get up for vote later this week |
hiboyang
pushed a commit
to datapunchorg/superset
that referenced
this pull request
May 19, 2022
* Fix Athena timestamp literal format related: [apache#19969] * Update test_athena.py Update test * Update athena.py * Resolving CI/CD * lint Co-authored-by: Thinh Nguyen Duc <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>
villebro
pushed a commit
that referenced
this pull request
May 26, 2022
* Fix Athena timestamp literal format related: [#19969] * Update test_athena.py Update test * Update athena.py * Resolving CI/CD * lint Co-authored-by: Thinh Nguyen Duc <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> (cherry picked from commit 8531546)
michael-s-molina
pushed a commit
that referenced
this pull request
May 26, 2022
* Fix Athena timestamp literal format related: [#19969] * Update test_athena.py Update test * Update athena.py * Resolving CI/CD * lint Co-authored-by: Thinh Nguyen Duc <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> (cherry picked from commit 8531546)
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* Fix Athena timestamp literal format related: [apache#19969] * Update test_athena.py Update test * Update athena.py * Resolving CI/CD * lint Co-authored-by: Thinh Nguyen Duc <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>
mistercrunch
added
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: [#19969]
from AWS official docs