-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make CTA text in Alerts & Reports mails configurable #19779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward to me, so I'll approve... just pointing out the risk that if someone actually changes that value in their config, the translations will not likely exist.
Closing/reopening to kick-start CI. Sorry this fell between the couch cushions for so long! Please feel free to nag us more here or on Slack if this happens again! Thank you! |
Codecov Report
@@ Coverage Diff @@
## master #19779 +/- ##
===========================================
- Coverage 66.51% 55.75% -10.76%
===========================================
Files 1686 1859 +173
Lines 64589 71036 +6447
Branches 6635 7766 +1131
===========================================
- Hits 42959 39605 -3354
- Misses 19931 29409 +9478
- Partials 1699 2022 +323
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@rusackas no worries, repo is busy like a bee hive already so don't want to ping much. Thanks for your hard work! |
SUMMARY
This PR makes call-to-action link text used in Alerts & Reports emails configurable
ADDITIONAL INFORMATION