-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected #19761
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19761 +/- ##
==========================================
+ Coverage 66.47% 66.53% +0.06%
==========================================
Files 1727 1714 -13
Lines 64724 65059 +335
Branches 6822 6731 -91
==========================================
+ Hits 43024 43290 +266
- Misses 19969 20058 +89
+ Partials 1731 1711 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8163958
to
116484a
Compare
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.88.112.129:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! looks good.
@@ -33,6 +34,7 @@ export const annotationsAndLayersControls: ControlPanelSectionConfig = { | |||
label: '', | |||
default: annotationLayers, | |||
description: t('Annotation Layers'), | |||
renderTrigger: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenLYZ the renderTrigger == ture
means that client rerenders and doesn't send a query, but here is an exception. add a comment here. Thanks!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR fixes the problem with the behavior of apply button in the annotation layer modal.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
nvd3. not trigger the overlay of run query
2022-04-18.11.58.56.mov
echart
2022-04-19.12.01.59.mov
after
2022-04-19.12.00.42.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION