Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected #19761

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the problem with the behavior of apply button in the annotation layer modal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

nvd3. not trigger the overlay of run query

2022-04-18.11.58.56.mov

echart

2022-04-19.12.01.59.mov

after

2022-04-19.12.00.42.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ stephenLYZ changed the title fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected Apr 18, 2022
@pull-request-size pull-request-size bot added size/L and removed size/S labels Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #19761 (8163958) into master (c8fe518) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 8163958 differs from pull request most recent head 116484a. Consider uploading reports for the commit 116484a to get more accurate results

@@            Coverage Diff             @@
##           master   #19761      +/-   ##
==========================================
+ Coverage   66.47%   66.53%   +0.06%     
==========================================
  Files        1727     1714      -13     
  Lines       64724    65059     +335     
  Branches     6822     6731      -91     
==========================================
+ Hits        43024    43290     +266     
- Misses      19969    20058      +89     
+ Partials     1731     1711      -20     
Flag Coverage Δ
javascript 51.28% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...art-controls/src/sections/annotationsAndLayers.tsx 100.00% <ø> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 92.85% <ø> (+6.19%) ⬆️
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 56.38% <0.00%> (-2.57%) ⬇️
...rset-frontend/src/components/CachedLabel/index.tsx 50.00% <0.00%> (-33.34%) ⬇️
superset/sql_validators/__init__.py 80.00% <0.00%> (-20.00%) ⬇️
...set-frontend/src/components/ReportModal/styles.tsx 87.87% <0.00%> (-12.13%) ⬇️
...set-frontend/src/explore/components/ChartPills.tsx 88.88% <0.00%> (-11.12%) ⬇️
...ns/legacy-plugin-chart-map-box/src/controlPanel.ts 25.00% <0.00%> (-8.34%) ⬇️
...rc/explore/components/ExploreChartHeader/index.jsx 43.10% <0.00%> (-8.25%) ⬇️
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8fe518...116484a. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Jun 2, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

@rusackas Ephemeral environment spinning up at http://52.88.112.129:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks good.

@@ -33,6 +34,7 @@ export const annotationsAndLayersControls: ControlPanelSectionConfig = {
label: '',
default: annotationLayers,
description: t('Annotation Layers'),
renderTrigger: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephenLYZ the renderTrigger == ture means that client rerenders and doesn't send a query, but here is an exception. add a comment here. Thanks!

@stephenLYZ stephenLYZ merged commit 9f02ff6 into apache:master Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Ephemeral environment shutdown and build artifacts deleted.

@zhaoyongjie zhaoyongjie mentioned this pull request Jul 11, 2022
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants