fix: can't save dataset modal

[zhaoyongjie]

SUMMARY

fix: can't save dataset modal

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[jinghua-qa]

/testenv up

[github-actions]

@jinghua-qa Ephemeral environment spinning up at http://52.32.199.162:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

LGTM!

Screen.Recording.2022-03-30.at.11.51.26.PM.mov

[codecov]

Codecov Report

Merging #19452 (71017ad) into master (129063d) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 71017ad differs from pull request most recent head 279cf3e. Consider uploading reports for the commit 279cf3e to get more accurate results

@@            Coverage Diff             @@
##           master   #19452      +/-   ##
==========================================
- Coverage   66.57%   66.53%   -0.05%     
==========================================
  Files        1675     1675              
  Lines       64092    64092              
  Branches     6519     6519              
==========================================
- Hits        42672    42643      -29     
- Misses      19729    19758      +29     
  Partials     1691     1691              

Flag	Coverage Δ
hive	52.70% <0.00%> (ø)
mysql	?
postgres	81.95% <0.00%> (ø)
presto	52.55% <0.00%> (ø)
python	82.30% <0.00%> (-0.10%)	⬇️
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/datasource/views.py	90.21% <0.00%> (ø)
superset/common/utils/dataframe_utils.py	85.71% <0.00%> (-7.15%)	⬇️
superset/connectors/sqla/utils.py	88.76% <0.00%> (-5.62%)	⬇️
superset/db_engine_specs/sqlite.py	91.89% <0.00%> (-5.41%)	⬇️
superset/db_engine_specs/mysql.py	93.97% <0.00%> (-3.62%)	⬇️
superset/utils/celery.py	86.20% <0.00%> (-3.45%)	⬇️
superset/result_set.py	96.77% <0.00%> (-1.62%)	⬇️
superset/databases/commands/test_connection.py	98.57% <0.00%> (-1.43%)	⬇️
superset/utils/cache.py	73.58% <0.00%> (-0.95%)	⬇️
superset/models/core.py	88.33% <0.00%> (-0.72%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129063d...279cf3e. Read the comment docs.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[sadpandajoe]

🏷️ preset:2022.13