Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove FilterbaleTableStyles.less #19442

Merged
merged 2 commits into from
Apr 4, 2022
Merged

chore: Remove FilterbaleTableStyles.less #19442

merged 2 commits into from
Apr 4, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 30, 2022

SUMMARY

Removes the FilterbaleTableStyles.less file

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

  1. Go to SQL lab
  2. Run a query that has results
  3. Verify that the table has no visual changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19442 (472f992) into master (fa35109) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19442      +/-   ##
==========================================
- Coverage   66.59%   66.54%   -0.05%     
==========================================
  Files        1670     1673       +3     
  Lines       63888    64059     +171     
  Branches     6510     6537      +27     
==========================================
+ Hits        42544    42631      +87     
- Misses      19654    19729      +75     
- Partials     1690     1699       +9     
Flag Coverage Δ
javascript 51.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <ø> (ø)
...src/components/FilterableTable/FilterableTable.tsx 71.42% <100.00%> (ø)
.../components/ExploreAdditionalActionsMenu/index.jsx 57.14% <0.00%> (-38.32%) ⬇️
...set-frontend/src/components/ReportModal/styles.tsx 87.50% <0.00%> (-12.50%) ⬇️
.../components/Header/HeaderActionsDropdown/index.jsx 67.79% <0.00%> (-3.64%) ⬇️
...rset-frontend/src/components/ReportModal/index.tsx 78.46% <0.00%> (-3.63%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 70.88% <0.00%> (-1.85%) ⬇️
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 43.85% <0.00%> (-0.97%) ⬇️
...rontend/src/dashboard/components/DashboardGrid.jsx 62.50% <0.00%> (-0.55%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 60.92% <0.00%> (-0.46%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa35109...472f992. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 7914296 into apache:master Apr 4, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Remove FilterbaleTablesStyles less

* Add theme top level
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants