Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove crud.less from Datasource #19438

Merged
merged 4 commits into from
Apr 7, 2022
Merged

chore: Remove crud.less from Datasource #19438

merged 4 commits into from
Apr 7, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 30, 2022

SUMMARY

Removes the crud.less file from the Datasource component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

  1. Go to Explore
  2. Open the Edit dataset modal
  3. Make sure there are no visual changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from michael-s-molina March 30, 2022 14:39
@codecov
Copy link

codecov bot commented Apr 1, 2022 •
edited
Loading

Codecov Report

Merging #19438 (3fc6f34) into master (fa35109) will increase coverage by 0.00%.
The diff coverage is 66.54%.

❗ Current head 3fc6f34 differs from pull request most recent head 7525f00. Consider uploading reports for the commit 7525f00 to get more accurate results

@@           Coverage Diff            @@
##           master   #19438    +/-   ##
========================================
  Coverage   66.59%   66.59%            
========================================
  Files        1670     1678     +8     
  Lines       63888    64242   +354     
  Branches     6510     6539    +29     
========================================
+ Hits        42544    42784   +240     
- Misses      19654    19763   +109     
- Partials     1690     1695     +5
Flag Coverage Δ
javascript 51.34% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <ø> (ø)
...legacy-plugin-chart-calendar/src/ReactCalendar.jsx 0.00% <0.00%> (ø)
...cy-plugin-chart-calendar/src/vendor/cal-heatmap.js 0.00% <ø> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <ø> (ø)
...s/legacy-plugin-chart-heatmap/src/ReactHeatmap.jsx 0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-rose/src/ReactRose.jsx 0.00% <0.00%> (ø)
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/ReactWorldMap.jsx 0.00% <0.00%> (ø)
...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx 0.00% <ø> (ø)
...t-deckgl/src/components/BootstrapSliderWrapper.jsx 0.00% <0.00%> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa35109...7525f00. Read the comment docs.

michael-s-molina
michael-s-molina reviewed Apr 1, 2022
View reviewed changes
superset-frontend/src/components/Datasource/CollectionTable.tsx Outdated
text-align: right;
}
.empty-collection {
padding: ${({ theme }) => theme.gridUnit * 2 + 2}px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use theme the hard way 😉

michael-s-molina
michael-s-molina reviewed Apr 4, 2022
View reviewed changes
superset-frontend/src/components/Datasource/CollectionTable.tsx
text-align: right;
}
.empty-collection {
padding: ${theme.gridUnit * 2 + 2}px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you removed the .control-label and .frame classes. It was intended?

Copy link
Member Author

@geido geido Apr 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-s-molina yes I checked and those two are unused. Did you find otherwise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I just wanted to confirm that it was removed intentionally.

michael-s-molina
michael-s-molina approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit e8f3e8a into apache:master Apr 7, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@geido @philipher29
chore: Remove crud.less from Datasource (apache#19438)
9e9baec 
* Remove crud less

* Remove unused classname

* Remove unused import

* Add theme top level
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/M 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geido @michael-s-molina @mistercrunch