-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate old API and create new API for dashes created by me #19434
feat: deprecate old API and create new API for dashes created by me #19434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19434 +/- ##
==========================================
- Coverage 66.66% 66.58% -0.08%
==========================================
Files 1678 1680 +2
Lines 64261 64293 +32
Branches 6561 6564 +3
==========================================
- Hits 42837 42812 -25
- Misses 19723 19779 +56
- Partials 1701 1702 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, waiting to rereview once the refactor proposed by @eschutho has been done.
Co-authored-by: Ville Brofeldt <[email protected]>
…nto feat/dashboards-created-by-me
…pache#19434) * feat: deprecate old API and create new API for dashes created by me * add tests * fix previous test * fix test and lint * fix sqlite test * fix lint * fix lint * lint * fix tests * fix tests * use dashboards get list instead * clean unnecessary marshmallow schema * Update superset/views/core.py Co-authored-by: Ville Brofeldt <[email protected]> * lint Co-authored-by: Ville Brofeldt <[email protected]>
SUMMARY
Following plan to gradually deprecate "REST" endpoints on
/superset
namespace.Deprecates
/superset/created_dashboards/<int:user_id>/
. Proposed removal on Superset 3.0Replaced by an existing endpoint
/api/v1/dashboard/
, includes the necessary frontend migration.TESTING INSTRUCTIONS
Navigate to the user profile and assert that created dashboards renders correctly
ADDITIONAL INFORMATION