-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: weight tooltip issue #19397
fix: weight tooltip issue #19397
Conversation
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/Screengrid.jsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #19397 +/- ##
==========================================
- Coverage 66.59% 66.53% -0.06%
==========================================
Files 1670 1672 +2
Lines 63888 63952 +64
Branches 6510 6519 +9
==========================================
+ Hits 42544 42552 +8
- Misses 19655 19709 +54
- Partials 1689 1691 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix: weight tooltip issue * remove console (cherry picked from commit f6d550b)
🏷️ preset:2022.13 |
* fix: weight tooltip issue * remove console
SUMMARY
Screen grid visualization shows Weight undefined
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION