-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explore): UI changes in dataset panel on Explore page #19394
Conversation
I love the changes! Really improved the user experience. cc @kasiazjc I have one suggestion that may be tackled in a separate PR if you wish. Can we make the draggable image respect the border-radius and width of the original component? If we do that, when the user is dropping, it will fit exactly in the droppable area 🤩 Screen.Recording.2022-03-28.at.2.58.13.PM.mov |
superset-frontend/src/explore/components/DatasourcePanel/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the amazing changes @kgabryje! It looks so much better!
Codecov Report
@@ Coverage Diff @@
## master #19394 +/- ##
=======================================
Coverage 66.48% 66.49%
=======================================
Files 1670 1670
Lines 63968 63971 +3
Branches 6512 6510 -2
=======================================
+ Hits 42531 42535 +4
+ Misses 19748 19747 -1
Partials 1689 1689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8a797f5
to
cdac852
Compare
SUMMARY
This PR implements several UI changes in Explore's dataset panel.
List of changes:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Verify that everything works like before
ADDITIONAL INFORMATION
CC @kasiazjc