fix(presto/trino): Add TIME/TIMESTAMP WITH TIME ZONE

[john-bodley]

SUMMARY

Presto (and thus Trino) have specific TIME and TIMESTAMP types which support time zones. If the underlying column type is TIMESTAMP WITH TIME ZONE then the PrestoEngineSpec.convert_dttm method would incorrectly format the Python datatime as a SQL string literal as opposed to casting it to a TIMESTAMP.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added unit tests and conformed in Presto:

1. That the from_iso8601_timestamp UDF supported time zones, i.e., from_iso8601_timestamp('2022-01-01T01:23:46.600+00:00')
2. That Presto supported a comparison between a time zone aware and time zone naive (defaulting to the time zone of the database engine) timestamp, i.e., TIMESTAMP SELECT TIMESTAMP '2001-08-22 03:04:05.321 America/Los_Angeles' > TIMESTAMP '2001-08-22 03:04:05.321' returned true for a Presto server using a UTC-localized time zone.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19263 (a813bad) into master (d645579) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a813bad differs from pull request most recent head 299f6b0. Consider uploading reports for the commit 299f6b0 to get more accurate results

@@           Coverage Diff           @@
##           master   #19263   +/-   ##
=======================================
  Coverage   66.53%   66.54%           
=======================================
  Files        1667     1667           
  Lines       64360    64362    +2     
  Branches     6493     6493           
=======================================
+ Hits        42824    42827    +3     
+ Misses      19854    19853    -1     
  Partials     1682     1682           

Flag	Coverage Δ
hive	52.65% <50.00%> (+<0.01%)	⬆️
mysql	81.49% <100.00%> (+<0.01%)	⬆️
postgres	81.53% <100.00%> (+<0.01%)	⬆️
presto	52.49% <75.00%> (+<0.01%)	⬆️
python	81.95% <100.00%> (+<0.01%)	⬆️
sqlite	81.30% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/presto.py	89.12% <100.00%> (ø)
superset/db_engine_specs/trino.py	71.68% <100.00%> (+0.88%)	⬆️
superset/utils/core.py	89.83% <100.00%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d645579...299f6b0. Read the comment docs.

[zhaoyongjie]

LGTM. BTW, Postgresql has timestamp with time zone as well, we can add to pg specs in the future.