fix: adhoc column in legacy chart

[zhaoyongjie]

SUMMARY

Currently, If a chart applied Adhoc Column and it was a legacy chart without QueryContext in slice metadata, user will see an error on Dashboard: TypeError: unhashable type: 'dict'.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

adhoc.column.before.mov

After

after.mov

TESTING INSTRUCTIONS

a) use following step to reproduce this issue

1. open USA Births Names in examples dashboard.
2. open Boy chart
3. add or change a Adhoc Column on the chart, then save and overwrite.
4. manually remove QueryContext for Boy chart from Superset metadata
   i) connect to Superset metadata by any database client or SQLLab
   ii) run SQL UPDATE slices set query_context=NULL WHERE slices.slice_name='Boys' in DB
5. open USA Births Names, reproduced
6. after this PR, will not see errors anymore

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19234 (c78fc04) into master (cfb967f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19234      +/-   ##
==========================================
+ Coverage   66.73%   66.76%   +0.02%     
==========================================
  Files        1668     1670       +2     
  Lines       64271    64392     +121     
  Branches     6496     6496              
==========================================
+ Hits        42894    42992      +98     
- Misses      19695    19718      +23     
  Partials     1682     1682              

Flag	Coverage Δ
hive	52.55% <0.00%> (-0.11%)	⬇️
mysql	81.96% <100.00%> (-0.01%)	⬇️
postgres	82.01% <100.00%> (-0.01%)	⬇️
presto	52.39% <0.00%> (-0.11%)	⬇️
python	82.43% <100.00%> (-0.01%)	⬇️
sqlite	81.76% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/connectors/base/models.py	88.61% <100.00%> (+0.03%)	⬆️
superset/datasets/api.py	88.28% <0.00%> (-3.61%)	⬇️
superset/views/sql_lab.py	59.33% <0.00%> (-1.36%)	⬇️
superset/dashboards/api.py	92.20% <0.00%> (-0.34%)	⬇️
superset/views/core.py	75.77% <0.00%> (-0.09%)	⬇️
superset/config.py	91.82% <0.00%> (-0.03%)	⬇️
superset/viz.py	58.26% <0.00%> (ø)
superset/databases/api.py	93.99% <0.00%> (ø)
superset/models/sql_lab.py	91.55% <0.00%> (ø)
superset/charts/data/api.py	89.80% <0.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb967f...c78fc04. Read the comment docs.

[ktmud]

LGTM with a couple of nits

[ktmud]

The updates LGTM.

Not super necessary, but if you can link to the code path that raises the error in the PR description, that'd be great.

[zhaoyongjie]

The updates LGTM.

Not super necessary, but if you can link to the code path that raises the error in the PR description, that'd be great.

This issue is in the Preset' Shortcut. So I can't link.

[sadpandajoe]

🏷️ preset:2022.11