Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): make to show the correct owned objects #19223

Merged
merged 5 commits into from
Mar 21, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 16, 2022

SUMMARY

Making myself owner of a dashboard that was NOT created by me does not show in "Mine" tab on homepage

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

screen-dashboard-own-fail.mov

AFTER:

screen-dashboard-mine.mov

TESTING INSTRUCTIONS

How to reproduce bugs

  1. Click the "Dashboards" tab
  2. Hover over the actions panel
  3. Click the "Edit" button
  4. Make yourself the owner of the dashboard
  5. Click the "Save" button
  6. Go back to the "Home" page
  7. Select the "Mine" section in "Dashboard" panel
  8. Pay attention to the dashboards

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #19223 (91be446) into master (c07a707) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19223      +/-   ##
==========================================
+ Coverage   66.51%   66.75%   +0.23%     
==========================================
  Files        1667     1666       -1     
  Lines       64415    64316      -99     
  Branches     6503     6504       +1     
==========================================
+ Hits        42846    42931      +85     
+ Misses      19884    19702     -182     
+ Partials     1685     1683       -2     
Flag Coverage Δ
javascript 51.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 62.00% <ø> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 54.09% <ø> (ø)
superset-frontend/src/views/CRUD/utils.tsx 64.95% <100.00%> (ø)
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx 74.74% <100.00%> (+0.25%) ⬆️
superset/views/css_templates.py 90.90% <0.00%> (-5.76%) ⬇️
superset/extensions.py 93.90% <0.00%> (-4.91%) ⬇️
superset/views/annotations.py 77.27% <0.00%> (-4.70%) ⬇️
superset/views/chart/views.py 88.09% <0.00%> (-1.65%) ⬇️
superset/views/base.py 74.83% <0.00%> (-0.67%) ⬇️
superset/security/manager.py 94.72% <0.00%> (-0.38%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07a707...91be446. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 17, 2022
@prosdev0107
Copy link
Contributor Author

@diegomedina248

Can you review this PR and approve if it is good?

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 29cba2b into apache:master Mar 21, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>
@villebro
Copy link
Member

@prosdev0107 @diegomedina248 After this PR I'm getting this error toast on the Welcome page:
image

@diegomedina248
Copy link
Contributor

@prosdev0107 please review, I am able to reproduce the error as well.
It happens on initial load, if you then switch filters it works.

@prosdev0107
Copy link
Contributor Author

prosdev0107 commented Mar 25, 2022

@diegomedina248
I checked the this part code and I found that someone(I could see it from git history) made changes in this part after merging this PR.
I think that someone made the changes when rebase or merge master into his branch.

So I fixed issue and reopened PR.
#19372

villebro pushed a commit that referenced this pull request Apr 3, 2022
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>

(cherry picked from commit 29cba2b)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants