-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): make to show the correct owned objects #19223
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19223 +/- ##
==========================================
+ Coverage 66.51% 66.75% +0.23%
==========================================
Files 1667 1666 -1
Lines 64415 64316 -99
Branches 6503 6504 +1
==========================================
+ Hits 42846 42931 +85
+ Misses 19884 19702 -182
+ Partials 1685 1683 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can you review this PR and approve if it is good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(dashboard): make to show the correct owned objects * fix(dashboard): make to filter is reusable * fix(homepage): make sure the type Array<Filters>
@prosdev0107 @diegomedina248 After this PR I'm getting this error toast on the Welcome page: |
@prosdev0107 please review, I am able to reproduce the error as well. |
@diegomedina248 So I fixed issue and reopened PR. |
* fix(dashboard): make to show the correct owned objects * fix(dashboard): make to filter is reusable * fix(homepage): make sure the type Array<Filters> (cherry picked from commit 29cba2b)
SUMMARY
Making myself owner of a dashboard that was NOT created by me does not show in "Mine" tab on homepage
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
screen-dashboard-own-fail.mov
AFTER:
screen-dashboard-mine.mov
TESTING INSTRUCTIONS
How to reproduce bugs
ADDITIONAL INFORMATION